Implemented Bogo Sort in Crystal #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
june128
added
Implementation
Vexatos
force-pushed
the
bogo-sort-crystal
branch
from
a716372 to
221c775
Compare
|
Everything looks great, but I think that Crystal has a shuffle function so maybe it's good to use it? |
|
Good idea, probably. |
Vexatos
force-pushed
the
bogo-sort-crystal
branch
2 times, most recently
from
3b3e332 to
d764df2
Compare
NIFR91
reviewed
Oct 23, 2018
|
|
||
| def bogo_sort!(a) | ||
| while !is_sorted?(a) | ||
| a = a.shuffle |
There was a problem hiding this comment.
The function shuffle without ! creates a new array, remember that in crystal objects are passed by reference.
Suggested change
| a = a.shuffle | |
| a.shuffle! |
There was a problem hiding this comment.
Not that it matters, but sure.
Vexatos
force-pushed
the
bogo-sort-crystal
branch
from
d764df2 to
a0321cc
Compare
jiegillet
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roughly based on the Lua implementation.